[PATCH] Remove undocumented code, fix bug 12707

Jeremy Allison jra at samba.org
Wed Mar 22 13:03:38 UTC 2017


On Tue, Mar 21, 2017 at 08:53:03PM +0100, Volker Lendecke via samba-technical wrote:
> On Wed, Mar 22, 2017 at 07:12:34AM +1300, Andrew Bartlett via samba-technical wrote:
> > I'm sorry to say it, but this exchange is not reasonable, nor up to
> 
> I am asked with very definite words to document code that I have
> written more than 12 years ago and not worked on it since then. I am
> sure that right now Andreas is much deeper in the code than I am and
> yet the it is being seen as my duty to document my sins of the past?
> 
> No, thanks, this code is broken, unsupported and undocumented. Just
> remove it.

If it's out there, and a customer is using it, it can't get
arbitrarily pulled. You know how this works :-).

Best thing to do is just politely refuse Andreas's request,
not pull the code.

If he has dependent customers he has to document for them. It was
not policy to mandate docs at the time the modules was
added so you can't be forced to document the sins of the
past.

All IMHO of course :-).



More information about the samba-technical mailing list