[PATCH] Correctly handle !authoritative in the rpc-based auth backends

[Andrew Bartlett]

On Tue, 2017-03-21 at 16:10 +0100, Stefan Metzmacher wrote:
> Am 21.03.2017 um 08:59 schrieb Stefan Metzmacher via samba-technical:
> > Am 21.03.2017 um 00:06 schrieb Stefan Metzmacher via samba-
> > technical:
> > > Hi Volker,
> > > 
> > > > On Mon, Mar 20, 2017 at 10:54:59AM +0100, Stefan Metzmacher
> > > > wrote:
> > > > > I'm currently looking into this and I might have something
> > > > > that should
> > > > > do the job without changing too much within the next days.
> > > > 
> > > > Can you share your ideas?
> > > 
> > > https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/he
> > > ads/master3-auth
> > 
> > Ok,
> > https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/head
> > s/master3-auth-ok
> > contains the first preparation step that should not really change
> > the logic.
> 
> The following patchset also passed autobuild and should not change
> the
> logic.

Can you help me understand how this patch doesn't change the logic?

auth3: Don't try other auth modules on any error
https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=987e5ab6310
6f2d427fe11ad780962f2f1e317bf

Otherwise it looks OK.  I've been promising to write SamLogon tests all
week, I'm going to write those next which will give me a little more
confidence in changes to this area.  

We really need more tests here, ideally on SamLogon, even if they start
with running wbinfo -a and smbclient with more combinations.

Thank you so much for this great power of work, it is really, really
good to have your attention on this difficult area.

I've also looked at the master3-auth branch and I don't have any
concerns. 

Thanks,

Andrew Bartlett