[PATCH] Messaging improvements and fixes needed for auth logging

[Andrew Bartlett]

On Mon, 2017-03-20 at 09:05 -0400, Jim Brown via samba-technical wrote:
> This test condition is odd.
> Add a comment explaining why && dsize != 0?
> 
> On 3/20/17 03:21, Andrew Bartlett via samba-technical wrote:
> > @@ -509,7 +510,7 @@ int tdb_fetch_talloc(struct tdb_context *tdb,
> > TDB_DATA key,
> >   		return map_unix_error_from_tdb(err);
> >   	}
> >   
> > -	if (state.buf == NULL) {
> > +	if (state.buf.dptr == NULL && state.buf.dsize != 0) {
> >   		return ENOMEM;
> >   	}

Thanks.  That is me forgetting that talloc(ctx, 0) returns a pointer,
rather than returning NULL, so I don't need that exception.

I'll fix it up!

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba