[PATCH] Messaging improvements and fixes needed for auth logging

Volker Lendecke vl at samba.org
Mon Mar 20 09:35:00 UTC 2017


On Mon, Mar 20, 2017 at 08:21:13PM +1300, Andrew Bartlett via samba-technical wrote:
> To test the auth and authz logging, we decided to use the messaging
> layer (details in our auth-logging branch in Catalyst's repo), as we
> have bindings for that in python.
> 
> It turned out that there were a number of issues in these layers, both
> the incomplete python bindings (they never previously worked: the tests
> were not actually tests) and an issue in the serverid database due to
> the way tdb_fetch_talloc() behaved with zero-length records.
> 
> The attached patches addresses both issues and allows us to build a
> robust testsuite for authentication and authorization logging!
> 
> Please review!

Standard initial comment: Please keep below 80 columns per line. Do
you need me to do that, or will you be able to do it yourself?

Thanks, Volker



More information about the samba-technical mailing list