[PATCH] Add two more tests for substitutions

Andreas Schneider asn at samba.org
Fri Mar 17 14:09:52 UTC 2017


On Friday, 17 March 2017 12:12:33 CET Andreas Schneider via samba-technical 
wrote:
> On Thursday, 16 March 2017 01:16:31 CET Jeremy Allison wrote:
> > On Wed, Mar 15, 2017 at 10:53:08AM -0700, Jeremy Allison via
> > samba-technical
> wrote:
> > > On Wed, Mar 15, 2017 at 01:12:12PM +0100, Andreas Schneider via samba-
> 
> technical wrote:
> > > > Hi,
> > > > 
> > > > attached are two tests to tests substitutions for the share path name
> > > > and also the 'template homedir'.
> > > > 
> > > > 
> > > > Review and push much appreciated!
> > > 
> > > Great work Andreas, thanks for these ! RB+ and pushed.
> > 
> > Andreas, I'm getting an autobuild fail on these with:
> > 
> > Can you look into this ?
> > 
> > Sorry,
> 
> Don't be sorry, this actually reveals a real bug! I opened:
> 
> 
> 	https://bugzilla.samba.org/show_bug.cgi?id=12699
> 
> 
> Could also be a regression, but I'm not sure!
> 
> 
> The attached patchset addresses the issue.
> 
> 
> Please review again.

I've looked into it with Volker and he spotted the correct fix. See 
attachment.


	Andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: subs_v2.patch
Type: text/x-patch
Size: 7867 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170317/bf527992/subs_v2.bin>


More information about the samba-technical mailing list