[PATCH] Correctly handle !authoritative in the rpc-based auth backends

Andrew Bartlett abartlet at samba.org
Thu Mar 16 21:54:11 UTC 2017


On Sat, 2017-03-11 at 14:40 +0100, Volker Lendecke wrote:
> On Sat, Mar 11, 2017 at 08:31:36AM +1300, Andrew Bartlett wrote:
> > On Fri, 2017-03-10 at 15:08 +0100, Volker Lendecke wrote:
> > > On Fri, Mar 10, 2017 at 05:46:58PM +1300, Andrew Bartlett wrote:
> > > > 
> > > > The pdbtest patch looks wrong, we have been testing the
> > > > different
> > > > auth
> > > > methods via that tool, so fixing it to 'sam' seems to be
> > > > limiting
> > > > what
> > > > we are testing.
> > > 
> > > Well, it does survive autobuild.
> > 
> > Sure, but that is because you remove what it is testing.  pdbtest
> > is
> > acting as the driver for a sort of unit test of the auth subsystem,
> > as
> > controlled by 'auth methods'.  The tests set auth methods to
> > various
> > values to try and test those modules.
> > 
> > This was added to ensure we didn't have untested code in the auth
> > subsystem and to avoid relying on indirect tests.
> 
> https://git.samba.org/?p=vl/samba.git/.git;h=refs/heads/auth
> 
> has fixes for this issue.
> 
> Comments?

Volker's repo above no longer contains that branch, so I attach the
patches here, so we can continue working on this patch series.

Andrew Bartlett
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vl-auth.patch
Type: text/x-patch
Size: 61296 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170317/23884c45/vl-auth.bin>


More information about the samba-technical mailing list