Removing SMB_VFS_STRICT_UNLOCK() ?

Ralph Böhme slow at samba.org
Thu Mar 16 21:08:43 UTC 2017


On Thu, Mar 16, 2017 at 11:48:22AM -0700, Jeremy Allison wrote:
> On Thu, Mar 16, 2017 at 08:56:46AM +0100, Ralph Böhme via samba-technical wrote:
> > Hi!
> > 
> > What abot removing SMB_VFS_STRICT_UNLOCK()? The only VFS that implements it is
> > vfs_default and it's a noop there.
> > 
> > Afaict it makes no sense anyway as per the strict locking specification (and
> > MS-FSA), SMB_VFS_STRICT_LOCK() only checks locks, it doesn't set any.
> > 
> > Thoughts?
> 
> Think it might have been added as an Isilon-specific thing.
> 
> Happy to lose this for 4.7, but only if you change the name
> of SMB_VFS_STRICT_LOCK() to SMB_VFS_STRICT_LOCK_CHECK()
> also, so it's obvious what it really does :-).

sounds like a plan. :)

Cheerio!
-slow



More information about the samba-technical mailing list