[PATCH] Two small cleanups

Ralph Böhme slow at samba.org
Thu Mar 16 21:06:44 UTC 2017


On Thu, Mar 16, 2017 at 12:29:48PM -0700, Jeremy Allison wrote:
> On Thu, Mar 16, 2017 at 10:11:37AM -0700, Jeremy Allison via samba-technical wrote:
> > On Thu, Mar 16, 2017 at 06:04:26PM +0100, Ralph Böhme via samba-technical wrote:
> > > On Thu, Mar 16, 2017 at 04:29:40PM +0100, Volker Lendecke wrote:
> > > > On Thu, Mar 16, 2017 at 10:56:17AM +0100, Ralph Böhme via samba-technical wrote:
> > > > > Hi!
> > > > > 
> > > > > Attached are two small cleanups for winbindd.
> > > > > 
> > > > > Please review & push if happy. Thanks!
> > > > 
> > > > Attached with my Review. While there -- I've added a patch on top to
> > > > squash. When touching code anyway I would appreciated to change it to
> > > > <80 chars per line.
> > > 
> > > I stopped after the two patches fixing the two things that annoyed me most and
> > > then forcing me to stop. Otherwise I would have done the long line fix as well
> > > plus another two fixes, ending with a patchset like the one attached. :)
> > > 
> > > Please review&push if happy. Thanks!
> > 
> > Bit late. I already pushed the original + squashed patches
> > as I was already doing an autobuild and just swept up
> > everything available on the list at the time (autobuilds
> > are *slow* these days :-).
> > 
> > Will apply this on top if it goes through, replace with
> > this if not !
> 
> And it failed, so pushing this instead !

:) Thanks!

Cheerio!
-slow



More information about the samba-technical mailing list