Patch for Bug 12559

Martin Schwenke martin at meltin.net
Thu Mar 16 00:34:36 UTC 2017


On Wed, 15 Mar 2017 16:47:54 -0700, Jeremy Allison via samba-technical
<samba-technical at lists.samba.org> wrote:

> On Wed, Mar 15, 2017 at 02:00:01PM -0400, Thomas Schulz via samba-technical wrote:
> > Here is a patch for Bug 12559 titled:
> > source3/lib/tldap.c", line 2539: non-constant initializer: op "NAME"  
> 
> With the commit message modified to include the bug link,
> RB+ Jeremy Allison <jra at samba.org>.
> 
> Can I get a second Team reviewer ?

Reviewed-by: Martin Schwenke <martin at meltin.net>

Do you have other things to push?  :-)

peace & happiness,
martin

> > From 908dc2784a2b821171c96c06db1e7940f88e8b79 Mon Sep 17 00:00:00 2001
> > From: Tom <schulz at adi.com>
> > Date: Wed, 15 Mar 2017 12:06:19 -0400
> > Subject: [PATCH] Fix for Solaris C compiler.
> > 
> > Inspired by comment 4 in bug 12559.
> > Signed-off-by: Tom Schulz <schulz at adi.com>
> > ---
> >  source3/include/tldap.h | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/source3/include/tldap.h b/source3/include/tldap.h
> > index 74279a4..23e3f1b 100644
> > --- a/source3/include/tldap.h
> > +++ b/source3/include/tldap.h
> > @@ -47,9 +47,15 @@ struct tldap_mod {
> >  	DATA_BLOB *values;
> >  };
> >  
> > +#if defined(HAVE_IMMEDIATE_STRUCTURES)
> >  typedef struct { uint8_t rc; } TLDAPRC;
> >  #define TLDAP_RC(x) ((TLDAPRC){.rc = x})
> >  #define TLDAP_RC_V(x) ((x).rc)
> > +#else
> > +typedef uint8_t TLDAPRC;
> > +#define TLDAP_RC(x) (x)
> > +#define TLDAP_RC_V(x) (x)
> > +#endif
> >  
> >  #define TLDAP_RC_EQUAL(x,y) (TLDAP_RC_V(x)==TLDAP_RC_V(y))
> >  #define TLDAP_RC_IS_SUCCESS(x) TLDAP_RC_EQUAL(x,TLDAP_SUCCESS)
> > -- 
> > 2.6.1
> > 
> > 
> > Tom Schulz
> > Applied Dynamics Intl.
> > schulz at adi.com
> >   
> 



More information about the samba-technical mailing list