[PATCH] (coverity fix) s3:smbd: exit early if srv_send_smb fails
Ralph Böhme
slow at samba.org
Wed Mar 15 18:03:26 UTC 2017
On Wed, Mar 15, 2017 at 10:34:03AM -0700, Jeremy Allison wrote:
> On Wed, Mar 15, 2017 at 06:27:56PM +0100, Ralph Böhme via samba-technical wrote:
> > On Wed, Mar 15, 2017 at 10:09:31AM -0700, Jeremy Allison via samba-technical wrote:
> > > On Wed, Mar 15, 2017 at 11:43:01AM +0100, Aurélien Aptel via samba-technical wrote:
> > > > Hi,
> > > >
> > > > Here's a quick patch that checks srv_send_smb return code and exits
> > > > early if it fails.
> > > >
> > > > Please review and push.
> > >
> > > LGTM. Reviewed-by: Jeremy Allison <jra at samba.org>
> > >
> > > Can I get a second Team reviewer ?
> >
> > +1
> >
> > Can you push?
>
> Sure - can you send me your modified version of my locking
> optimization fix and I'll push them together (for some
> reason I didn't see your push come through) ?
yeah, was queue, then never scheduled, then failed. Currently running and needs
just a few more minutes, so I'd say lets leave it running.
Cheerio!
-slow
More information about the samba-technical
mailing list