[PATCH] Correctly handle !authoritative in the rpc-based auth backends

Andrew Bartlett abartlet at samba.org
Fri Mar 10 19:31:36 UTC 2017


On Fri, 2017-03-10 at 15:08 +0100, Volker Lendecke wrote:
> On Fri, Mar 10, 2017 at 05:46:58PM +1300, Andrew Bartlett wrote:
> > 
> > The pdbtest patch looks wrong, we have been testing the different
> > auth
> > methods via that tool, so fixing it to 'sam' seems to be limiting
> > what
> > we are testing.
> 
> Well, it does survive autobuild.

Sure, but that is because you remove what it is testing.  pdbtest is
acting as the driver for a sort of unit test of the auth subsystem, as
controlled by 'auth methods'.  The tests set auth methods to various
values to try and test those modules.

This was added to ensure we didn't have untested code in the auth
subsystem and to avoid relying on indirect tests.

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list