[PATCH] Implement msDS-RevealedUsers for RODC auditing

[Garming Sam]

On 09/03/17 22:50, Stefan Metzmacher wrote:
> I think some of the commits can be squashed, e.g.
>   getncchanges: Add a comment for new function
>   getncchanges: Reorder parameters in filter_attrs for ...
> and
>   objectclass_attrs: Add comments linking back to ADTS

I'll definitely squash these ones.

> All in all it looks like we basically need a similar logic
> compared to authsam_make_user_info_dc, maybe we can
> share more code and have these calculation just in
> one code path, by making use of tokenGroups* in all places
> and a relatively simple wrapper to build the full sid list.
>
> If it turns out to be too complex to unify this at least
> add a comment that refers to sIDHistory, so that I'll find
> that place in a git grep later, when I finish this commit
> https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=513a727a3d5755b3a7453387577690c76348d739

I will take a look and see what I make of it. I'm rapidly running out of
time available for this task, so a comment seems likely.


Thanks,

Garming