[PATCH][RFC] Make Samba faster by removing o(n) search in ltdb_is_indexed
Andrew Bartlett
abartlet at samba.org
Thu Mar 9 04:06:53 UTC 2017
On Thu, 2017-03-09 at 16:34 +1300, Andrew Bartlett wrote:
> This patch appears to address a performance issue during search
> and modify attempting to determine if an attribute is in an index.
>
> Our ldb_schema_attribute_by_name() in Samba uses a binary search
> on the schema, and we now set the index flag there in that case.
>
> Otherwise we fall back to a scan over the index list (no attempt is
> made to try and merge the index values and attribute values in the
> general case).
>
> Douglas will do some perf tests on this soon.
The attached patch passes more tests. A full test run is in progress.
Andrew Bartlett
> Please comment!
>
> Thanks,
>
> Andrew Bartlett
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ldb-Allow-Samba-to-handle-the-list-of-attributes-wit.patch
Type: text/x-patch
Size: 39536 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170309/6f4116ca/0001-ldb-Allow-Samba-to-handle-the-list-of-attributes-wit.bin>
More information about the samba-technical
mailing list