[PATCH][RFC] Make Samba faster by removing o(n) search in ltdb_is_indexed

Andrew Bartlett abartlet at samba.org
Thu Mar 9 03:34:33 UTC 2017


This patch appears to address a performance issue during search
and modify attempting to determine if an attribute is in an index.

Our ldb_schema_attribute_by_name() in Samba uses a binary search
on the schema, and we now set the index flag there in that case.

Otherwise we fall back to a scan over the index list (no attempt is
made to try and merge the index values and attribute values in the
general case). 

Douglas will do some perf tests on this soon.

Please comment!

Thanks,

Andrew Bartlett
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ldb-Allow-Samba-to-handle-the-list-of-attributes-wit.patch
Type: text/x-patch
Size: 34408 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170309/d48d7170/0001-ldb-Allow-Samba-to-handle-the-list-of-attributes-wit.bin>


More information about the samba-technical mailing list