[PATCH] Simplify auth_check_ntlm_password

Andrew Bartlett abartlet at samba.org
Wed Mar 8 00:54:18 UTC 2017


On Tue, 2017-03-07 at 23:39 +0100, Volker Lendecke wrote:
> On Tue, Mar 07, 2017 at 01:52:28PM -0800, Jeremy Allison wrote:
> > +               if (!NT_STATUS_IS_OK(nt_status)) {
> > +                       static const struct dom_sid null_sid = {0};
> > +                       sid = null_sid;
> > +               }
> 
> While there -- please don't ever add this kind of static. We have a
> null sid, we also can do sid = (struct dom_sid) {0}. But not this
> kind
> of static please.

Thanks, that is a much nicer construct!

Andrew Bartlett



More information about the samba-technical mailing list