[PATCH] Simplify auth_check_ntlm_password

Volker Lendecke vl at samba.org
Tue Mar 7 22:39:15 UTC 2017


On Tue, Mar 07, 2017 at 01:52:28PM -0800, Jeremy Allison wrote:
> +               if (!NT_STATUS_IS_OK(nt_status)) {
> +                       static const struct dom_sid null_sid = {0};
> +                       sid = null_sid;
> +               }

While there -- please don't ever add this kind of static. We have a
null sid, we also can do sid = (struct dom_sid) {0}. But not this kind
of static please.

Thanks,

Volker



More information about the samba-technical mailing list