[PATCH] Simplify auth_check_ntlm_password

Andrew Bartlett abartlet at samba.org
Tue Mar 7 21:04:19 UTC 2017


On Tue, 2017-03-07 at 14:28 +0100, Volker Lendecke wrote:
> Hi!
> 
> While working on the auth code I had a hard time following the logic
> in auth_check_ntlm_password. The attached patchset is supposed to
> make
> that more traceable. It does not change behaviour, those patches will
> come at a later step and will make the routine even simpler. The
> behaviour change will be to always break out of the loop if
> 
> !NT_STATUS_EQUAL(nt_status,NT_STATUS_NOT_IMPLEMENTED);
> 
> Review appreciated!

Thanks Volker, these look like a helpful start to making this stuff
simpler.  

I looked at this set last night, to see how it works with the
authentication audit code (so I could integrate into that series it as
promised).  Putting it in before causes rebase pain, so I'll take a
look at adding it after and see if it is any less difficult.

Otherwise I'll take the concepts and apply them once we are done.  

I hope it is OK to delay these a little, the auth logging patch series
does great things, but hasn't yet got the required review (and is still
improving).  

I know we normally work on a 'race to master' principle, but if you can
wait on this one it will be most appreciated, we don't expect to be
more than a few more days.

Thanks,

Andrew Bartlett




More information about the samba-technical mailing list