[PATCH] Python3 compatible modules - credentials, param, _glue

[Petr Viktorin]

On 03/06/2017 10:44 AM, Andrew Bartlett wrote:
> On Mon, 2017-03-06 at 15:47 +1300, Andrew Bartlett wrote:
>> On Thu, 2017-03-02 at 10:32 +0100, Lumir Balhar wrote:
>>>
>>> Hello.
>>>
>>> We are working on it. I fixed the issue with missing copyrights
>>> (patch
>>> attached) and now I am working on another one with pytalloc-util.
>>>
>>> The problem with pytalloc-util is only in autobuild and the reason
>>> is
>>> that pytalloc-util is created as a dependency in the same
>>> environment
>>> before build of samba-libs. Then during configuration of samba-
>>> libs,
>>> pytalloc-util is found as a system library. This means
>>> (unfortunately)
>>> that the build of pytalloc-util for Python is skipped and this
>>> missing
>>> dependency causes the problem during the build of samba-libs.
>>>
>>> Unfortunately, I don't know a solution for now. But this occurs
>>> only
>>> in
>>> autobuild.
>>
>> I'm sorry, I missed this e-mail.
>>
>> The purpose of the samba-libs build is to ensure that IF talloc were
>> installed as a system lib, Samba could build against it.  So we need
>> to
>> make it work.
>>
>>> If this build failure is not a problem or you know the solution, we
>>> can
>>> do a quick review of your branch and then agree with the merge.
>>>
>>> The Travis build: https://travis-ci.org/samba-team/samba/builds/206
>>> 10
>>> 6557
>>
>> The issue is that we need to find the python3 pytalloc-util.  This is
>> the first time we have relied on finding a python3 C library to link
>> against.
>
> It was a complex one, but I've fixed this issue in my py3 branch in mygithub and in
>
> git://git.samba.org/abartlet/samba.git py3
>
> Please do that review.  Likewise if another team member can review this
> branch it would be incredibly helpful, as we also have the --disable-
> python patches to merge once this is in.

So, when --extra-python is used, both the py2 and py3 version needs to 
be in the system, otherwise the internal copy is built for both Pythons. 
I believe that makes a lot of sense.


I see two problems, detailed in the attached patches. Please squash them 
in as needed.

-- 
Petr Viktorin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-buildtools-Install-the-right-pkgconfig-for-Python-3.patch
Type: text/x-patch
Size: 1081 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170307/cfa260dc/0001-buildtools-Install-the-right-pkgconfig-for-Python-3.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-buildtools-pytalloc-pyldb-Replace-underscore-by-dash.patch
Type: text/x-patch
Size: 2223 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170307/cfa260dc/0002-buildtools-pytalloc-pyldb-Replace-underscore-by-dash.bin>