[PATCH post-py3 1-15/14] Re: Disabling Python Modules

Ian Stakenvicius axs at gentoo.org
Tue Mar 7 00:25:50 UTC 2017


On 06/03/17 01:13 PM, Andrew Bartlett wrote:
> On Mon, 2017-03-06 at 11:58 -0500, Ian Stakenvicius wrote:
>> On 06/03/17 10:10 AM, Ian Stakenvicius wrote:
>>>
>>> No problem.
>>>
>>> FYI, I'm getting a conflict in lib/talloc/wscript , where it looks
>>> like your patchset dropped the checks for the system copy of talloc
>>> when it's not being build standalone -- is it OK to drop
>>> this?  Gentoo
>>> Linux in particular -always- builds samba against system talloc, I
>>> expect other distros do the same..
>>>
>>> Wouldn't tevent need a check that is similar to what was done in
>>> lib/ldb/wscript?
>>>
>>
>> Hey Andrew, speaking of lib/ldb , autobuild tests are returning an
>> error related to a conflict in the ordering of the ldb and pyldb_util
>> builds:
>>
>>
>> Checking project rules ...
>> Target 'pyldb-util.cpython-34m' in build group 'generators' depends
>> on
>> target 'ldb' from later build group 'main'
>> Bad group ordering - aborting
>>
>>
>> This doesn't look to have anything to do with the changes my
>> disable-python patchset performs on top of your py3 patchset, but if
>> i'm wrong please let me know.  My code is in my 'disable-python-py3'
>> branch and the Travis-CI results are on PR#82
> 
> I got a full pass on my py3 branch overnight (a full autobuild), so I
> think those are OK.
> 
> I don't know what is going on here right now.
> 
> Sorry, 
> 
> Andrew Bartlett
> 

Sorted it -- I made an indentation error on ldb's wscript during the
rebase.

Attached is the full patchset, rebased on top of Andrew's py3 branch.
This is identical to PR#82, which is green on travis.

Please review; hopefully it'll finally be clean and good to commit.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: disable-python--after-py3.patch
Type: text/x-diff
Size: 36059 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170306/6237f598/disable-python--after-py3.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170306/6237f598/signature.sig>


More information about the samba-technical mailing list