RFC smbd smb2 quota support (+ patches to get rid of manual marshall/unmarshall by ndr-ising the existing code)

Noel Power nopower at suse.com
Thu Mar 2 16:26:39 UTC 2017


On 02/03/17 13:59, Noel Power wrote:
> On 02/03/17 12:09, Noel Power wrote:
>> Hi,
>>
>> I got curious after failing to get any useful response from the windows
>> quota dialog tab (win8.1 client) when connected to a samba share. Seems
>> smbd doesn't support some of the quota related messages in smb2. The
>> attached patches hope to fix that, additionally I tried to clean up some
>> of the code by removing some of the manual marshall/unmarshall code.
>>
>> The last patch in the series (PATCH 9) modifies build_user_quota_buffer,
>> the resulting function is quite similar to the fill_quota_buffer from
>> PATCH 4, the implementation could be made common for the client & smbd I
>> think (and probably live in libsmb somewhere) I'd be interested to hear
>> if that would be the correct place to put it (or even any other
>> suggestions). If it is ok I would like to do that as a followup patch
>>
>> Noel
>>
> <sigh> please hold off looking at these for the moment, it seems I have
> made some mistake when I was porting these from 4.x, I will post a new
> set of patches when I fix whatever extra mess I have made
>
please see (hopefully better) version 2 :/

Noel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: quota-v2.patch
Type: application/mbox
Size: 47674 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170302/308e3c16/quota-v2.mbox>


More information about the samba-technical mailing list