[PATCH] pass "authoritative" result from samlogon through libwbclient

Andrew Bartlett abartlet at samba.org
Wed Mar 1 20:55:03 UTC 2017


On Wed, 2017-03-01 at 21:43 +0100, Volker Lendecke wrote:
> On Thu, Mar 02, 2017 at 07:03:41AM +1300, Andrew Bartlett wrote:
> > On Wed, 2017-03-01 at 13:21 +0100, Volker Lendecke wrote:
> > > Hi!
> > > 
> > > No behaviour change intended, will be used later.
> > > 
> > > Review appreciated!
> > 
> > Thanks Volker.  This is important work.  
> > 
> > Can you make sure this flag is also returned to the IRPC client via
> > _winbind_SamLogon?
> 
> This was meant as a preparatory patchset to make the things more
> digestable piece by piece. Sorry if that confuses things more, I will
> keep the patches private until they are done.
> 
> Volker

Volker,

Please do post works in progress (marked as [WIP]), so we can all
understand what you are trying to do, it helps us greatly to understand
the context.

The flip side of that is: Please don't ask for review if you don't want
us to spot inconstancies, or comment about how they could be expanded
or wonder - even incorrectly - about where they are going.
  
Incremental patches are great, but please don't assume we can read your
mind!  

Finally, we all (myself and my team included) need to do better with
explaining, while are still in preparation, our goals ideas and plans. 
I know it is not the 'Samba way' (perhaps out of fear that the ideas
will be disagreed with), but it would really help the team.  

(To start, I'll write of some of the AD perf work my team is hoping to
work on soon). 

Thanks,

Andrew Bartlett



More information about the samba-technical mailing list