Releases, locking and ldb

Stefan Metzmacher metze at samba.org
Fri Jun 30 21:00:59 UTC 2017


Am 30.06.2017 um 22:23 schrieb Andrew Bartlett via samba-technical:
> On Fri, 2017-06-30 at 23:03 +1200, Andrew Bartlett via samba-technical
> wrote:
>>
>> Perhaps I'm tempting fate too much making changes after we got it all
>> working, but I've attached my current thoughts.  I wish I could do more
>> to actually remove the nested transactions, but now is not the time.
> 
> Indeed, fate tempted.  Even this smaller 'safe' set fails autobuild,
> which honestly scares me a little.  However we can't go down this rat-
> hole today. 

I've added the tdb_transaction_active(), but I'm not sure
it will be the way to fix things in ldb. There's more discussion
required. If we get something useful in the next weeks it can
be backported as bugfix, it's not required to fix all bugs before
4.7.0rc1.

https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-ldb-1
passed 'autobuild-private.sh samba samba-systemkrb5' twice. I'll some
complete autobuilds now.

I'll fix up the commit message and comments around the tests.

The important thing that's not tested yet is that the
ldb:wscript: define EXPECTED_SYSTEM_LDB_VERSION_{MAJOR,MINOR,RELEASE}
commit release works to reject builds with older samba versions.

metze


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170630/65732288/signature.sig>


More information about the samba-technical mailing list