[PATCH] Solve issues with flapping patches
slow at samba.org
Fri Jun 30 17:18:49 UTC 2017
On Fri, Jun 30, 2017 at 09:12:37AM -0700, Jeremy Allison via samba-technical wrote:
> On Fri, Jun 30, 2017 at 06:17:46AM +0200, Stefan Metzmacher via samba-technical wrote:
> > Am 30.06.2017 um 06:09 schrieb Martin Schwenke via samba-technical:
> > >
> > > I have vaguely noticed the work but it isn't on my radar. I need to
> > > get my code and the code it depends on into the tree. I would like to
> > > do that without having to push 3 or 4 times, every time.
> This is the critical thing. These tests are important, but if they're
> failing 75% of the time and preventing others from getting work
> upstream then it's time to mark flapping, and unmark them when
> the problem has been fixed.
> Andrew, I would understand your position if Martin was proposing
> removing the tests, but that's not what is being requested here.
> These tests are critical ! We must have them - but we have
> a known bug now that is being worked on so a little temporary
> relief is reasonable.
> All these tests are doing right now is making it painful for
> anyone to get work into upstream.
> This situation wouldn't be tolerated in commercial software
> development, and I don't think we should accept less for Samba.
> > > Those samba4.drs and samba4.ldap tests flap like wet towels hanging in a
> > > gentle breeze! They have topped the list of flapping tests for several
> > > months. They impede the productivity of team members who care less
> > > about them and care more about the code they're working on.
> > I'm fine with marking them as flapping, reviewed-by: me.
> > I'll revert the change once the real fixes are pushed
> > (in the next 1-5 days)
> +1 from me. Please push.
I agree as well, please push.
More information about the samba-technical