[PATCH] Solve issues with flapping patches

Martin Schwenke martin at meltin.net
Fri Jun 30 04:56:42 UTC 2017

On Fri, 30 Jun 2017 16:39:59 +1200, Andrew Bartlett
<abartlet at samba.org> wrote:

> On Fri, 2017-06-30 at 11:43 +1000, Martin Schwenke via samba-technical
> wrote:
> > * selftest: Mark some samba.drs and samba4.ldap tests as flapping
> > * ctdb-tests: Remove use of pstree to stop unit tests from flapping
> > 
> > Please review and maybe push...
> > 
> > Note that I expect a NACK for the 1st patch from Andrew and a NACK
> > for
> > the 2nd patch from Amitay.    
> Can you explain a little more the decreased sensitivity for your pstree
> -> ps change?  What is the practical impact?  

If either of the tests fails unexpectedly due to a bug in
eventd-related code then the absence/presence of child processes, which
we get from the pstree output, will help to debug the failure. For
example, if the 2nd test fails but only shows the event script process
(but not the sleep) then that tells us that there's something wrong
with script cleanup. With just ps we don't get that extra hint.

peace & happiness,

More information about the samba-technical mailing list