[PATCH] Solve issues with flapping patches

Andrew Bartlett abartlet at samba.org
Fri Jun 30 02:15:05 UTC 2017

On Fri, 2017-06-30 at 11:43 +1000, Martin Schwenke via samba-technical
> * selftest: Mark some samba.drs and samba4.ldap tests as flapping
> * ctdb-tests: Remove use of pstree to stop unit tests from flapping
> Please review and maybe push...
> Note that I expect a NACK for the 1st patch from Andrew and a NACK
> for
> the 2nd patch from Amitay.  However, at least we might have another
> useful discussion about flapping tests and which ones are important.

Have you see the work currently underway on this?

This is the result of the lack of DB level locking, which is a serious
consistency issue that I'm very glad was not swept under the carpet.

We could waste our time on a discussion about how we came to have no
read locking on our core user store, or what should have been done to
respond to the flapping tests earlier, or we could continue to focus
our efforts on landing the ldb and tdb changes required.

> Yes, that was very passive-aggressive and I shouldn't have done
> it... but at least I feel better... ;-)

I'm sure you do.


Andrew Bartlett
Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list