[PATCH] Multi-process perf test
douglas.bagnall at catalyst.net.nz
Thu Jun 29 01:56:41 UTC 2017
On 29/06/17 12:30, Andrew Bartlett wrote:
> On Thu, 2017-06-29 at 12:00 +1200, Douglas Bagnall wrote:
>> It seems the extra imports in the new files were cut-and-paste
>> inherited from ad_dc_multi_bind.py, so I have taken the liberty of
>> fixing them there and squashed it all into the attached patch. It
>> appears to run.
>> Also, line length and whitespace are close to perfect!
> Thanks Douglas.
> Regarding the ANCIENT_SAMBA stuff, given we require working python
> messaging, unless we backport that or it is reworked to just use
> os.pipe() it isn't going to be even on Samba 4.6, let alone < 4.3.
> Should we keep that just in case we backport, or just drop it?
Well, I doubt we'll backport it to 4.2, which is where ANCIENT_SAMBA
applies. If someone (like, probably you) wants to run these tests on
those versions they can backport as necessary in their own branches.
If you aren't planning such a backport, there is a very high chance
that the ANCIENT_SAMBA sections will never be run and thus should be
> Andrew Bartlett
> Andrew Bartlett http://samba.org/~abartlet/
> Authentication Developer, Samba Team http://samba.org
> Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical