[PATCH] s3:build_env.sh: allow to override build date

[Andrew Bartlett]

On Mon, 2017-06-26 at 14:32 +0200, David Disseldorp via samba-technical 
wrote:
> On Mon, 26 Jun 2017 21:40:12 +1200, Andrew Bartlett via samba-technical wrote:
> 
> > On Mon, 2017-06-26 at 11:21 +0200, Bernhard M. Wiedemann wrote:
> > > On 2017-06-26 11:10, Andrew Bartlett wrote:  
> > > > Thanks for trying to push this area of work upstream.  In this case I
> > > > would frankly prefer we just removed the variables rather than promote
> > > > further complexity.   
> > > 
> > > dropping them completely, would be fine, too.
> > > I was just assuming that they served someone's purpose  
> > 
> > For the history buffs, I added it with Vance in 2003:
> > 
> > 53004910ebe729809e7d3c9724f338d1b763be9b
> > 
> > I would like to at least hear objections to this approach before we
> > added more conditionals.  The reproducible builds effort is pretty
> > mainstream these days. 
> > 
> > Also, the build farm (which is a big part of why this got added) is not
> > longer with us, so we don't need to know as critically from the binary
> > output the build environment.
> > 
> > I'm sure someone still uses it (or thinks they could), it is just a
> > matter of if they can live without out, which I hope. 
> 
> You're only talking about dropping the BUILD_ENV_UNAME, BUILD_ENV_DATE,
> BUILD_ENV_SRCDIR, BUILD_ENV_BUILDDIR, BUILD_ENV_USER, BUILD_ENV_HOST and
> BUILD_ENV_COMPILER fields, not the entire "smbd -b" behaviour, right?

Yes.

> If so, I'd be in favour of that if it gets us closer to reproducible
> builds.

Exactly.

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba