[PATCH] s3:build_env.sh: allow to override build date

Andrew Bartlett abartlet at samba.org
Mon Jun 26 09:40:12 UTC 2017

On Mon, 2017-06-26 at 11:21 +0200, Bernhard M. Wiedemann wrote:
> On 2017-06-26 11:10, Andrew Bartlett wrote:
> > Thanks for trying to push this area of work upstream.  In this case I
> > would frankly prefer we just removed the variables rather than promote
> > further complexity. 
> dropping them completely, would be fine, too.
> I was just assuming that they served someone's purpose

For the history buffs, I added it with Vance in 2003:


I would like to at least hear objections to this approach before we
added more conditionals.  The reproducible builds effort is pretty
mainstream these days. 

Also, the build farm (which is a big part of why this got added) is not
longer with us, so we don't need to know as critically from the binary
output the build environment.

I'm sure someone still uses it (or thinks they could), it is just a
matter of if they can live without out, which I hope. 

> With dropping, in addition to the debian patches, several lines in
> buildtools/wafsamba/samba_patterns.py
> could be dropped then.


Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list