[PATCH] Add a test for 'net usershare'

Alexander Bokovoy ab at samba.org
Fri Jun 23 00:49:56 UTC 2017


On to, 22 kesä 2017, Jeremy Allison via samba-technical wrote:
> On Thu, Jun 22, 2017 at 04:38:44PM -0700, Jeremy Allison via samba-technical wrote:
> > On Thu, Jun 22, 2017 at 05:51:28PM +0200, Andreas Schneider via samba-technical wrote:
> > > Hi,
> > > 
> > > I've tried to understand a customer problem, so I've started to write a test 
> > > for 'net usershare'. Haven't found a bug yet, so here is just a test which 
> > > checks normal functionality.
> > > 
> > > 
> > > Review and push appreciated.
> > 
> > RB+. Thanks a *LOT* for the tests on this Andreas !
> 
> Ah, I spoke too soon. Fails with:
> 
> /memdisk/jra/a/b230827/samba/source3/script/tests/test_net_usershare.sh: 15: shift: can't shift that many
> command: /memdisk/jra/a/b230827/samba/source3/script/tests/test_net_usershare.sh $SERVER $SERVER_IP $USERNAME $PASSWORD /memdisk/jra/a/b230827/samba/bin/smbclient 2>&1  | /memdisk/jra/a/b230827/samba/selftest/filter-subunit --fail-on-empty --prefix="samba3.blackbox.net_usershare." --suffix="(fileserver:local)"
> expanded command: /memdisk/jra/a/b230827/samba/source3/script/tests/test_net_usershare.sh FILESERVER 127.0.0.35 jra fileserver /memdisk/jra/a/b230827/samba/bin/smbclient 2>&1  | /memdisk/jra/a/b230827/samba/selftest/filter-subunit --fail-on-empty --prefix="samba3.blackbox.net_usershare." --suffix="(fileserver:local)"
> ERROR: Testsuite[samba3.blackbox.net_usershare(fileserver:local)]
> REASON: Exit code was 1
I've fixed 'shift 6' to 'shift 5' and submitted with my RB+

-- 
/ Alexander Bokovoy



More information about the samba-technical mailing list