[PATCH] cifs: remove redundant return in cifs_creation_time_get

Steve French smfrench at gmail.com
Wed Jun 21 16:58:10 UTC 2017


merged into cifs-2.6.git for-next

On Tue, Jun 6, 2017 at 6:33 PM, Colin King <colin.king at canonical.com> wrote:

> From: Colin Ian King <colin.king at canonical.com>
>
> There is a redundant return in function cifs_creation_time_get
> that appears to be old vestigial code than can be removed. So
> remove it.
>
> Detected by CoverityScan, CID#1361924 ("Structurally dead code")
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  fs/cifs/xattr.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/fs/cifs/xattr.c b/fs/cifs/xattr.c
> index 3cb5c9e2d4e7..de50e749ff05 100644
> --- a/fs/cifs/xattr.c
> +++ b/fs/cifs/xattr.c
> @@ -188,8 +188,6 @@ static int cifs_creation_time_get(struct dentry
> *dentry, struct inode *inode,
>         pcreatetime = (__u64 *)value;
>         *pcreatetime = CIFS_I(inode)->createtime;
>         return sizeof(__u64);
> -
> -       return rc;
>  }
>
>
> --
> 2.11.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Thanks,

Steve


More information about the samba-technical mailing list