[PATCHES] GPO support for the AD DC itself

[Garming Sam]

Hi David,

I've just taken an initial look and it's looking reasonably good.

In the patch 'libgpo: Add libgpo python bindings' you remove a return
case in finalize_local_nt_token. Can you explain why? Where were you
using it and why is this necessary?

On the whole, it looks much improved. But there needs to be some more
comments (either in the code or the commit message) on what you're
actually doing. For instance, I notice that you've introduced GPO
unapply and it uses an xml log file. How is this file actually formatted
and used? Similarly, in applying krb5 settings, which settings does it
alter and how does it alter them? There needs to be some more high level
documentation, both for other developers and for users.
docs-xml/smbdotconf/domain/gpoupdatecommand.xml probably needs an
extensive list of what is and is not being applied for example because
it's not obvious at a glance.


Cheers,

Garming

On 17/06/17 04:04, David Mulder via samba-technical wrote:
> These patches were originally sent to the mailing list on 05 June 2014.
> New python bindings for getting gpo guids and correct apply order from
> libgpo. Completely rewritten samba_gpoupdate to use new python bindings.
> Added unapply.
> I would love to get these into 4.7. Feedback welcome!
>
>  ctdb/common/system.h                            |   1 -
>  ctdb/common/system_util.c                       |  49 +-----
>  ctdb/wscript                                    |   4 +-
>  docs-xml/smbdotconf/base/serverservices.xml     |   2 +-
>  docs-xml/smbdotconf/domain/gpoupdatecommand.xml |  14 ++
>  dynconfig/dynconfig.c                           |   1 +
>  dynconfig/dynconfig.h                           |   1 +
>  dynconfig/wscript                               |   2 +
>  lib/param/loadparm.c                            |   3 +-
>  lib/util/mkdir_p.c                              |  71 ++++++++
>  lib/util/mkdir_p.h                              |  22 +++
>  lib/util/wscript_build                          |   5 +
>  {source3/libgpo => libgpo}/gpo_filesync.c       |   0
>  libgpo/gpo_ldap.c                               |   4 +-
>  {source3/libgpo => libgpo}/gpo_proto.h          |   0
>  {source3/libgpo => libgpo}/gpo_reg.c            |   0
>  libgpo/pygpo.c                                  | 448
> +++++++++++++++++++++++++++++++++++++++++++++++++
>  libgpo/wscript_build                            |  12 ++
>  python/samba/gpclass.py                         | 387
> ++++++++++++++++++++++++++++++++++++++++++
>  python/samba/krb5parse.py                       |  67 ++++++++
>  python/samba/samdb.py                           |  18 ++
>  selftest/target/Samba4.pm                       |   1 +
>  source3/auth/token_util.c                       |   3 +-
>  source3/libgpo/gpext/wscript_build              |   4 -
>  source3/param/loadparm.c                        |   9 +-
>  source3/utils/wscript_build                     |   2 +-
>  source3/wscript_build                           |  19 ---
>  source4/dsdb/gpo/gpo_update.c                   | 191 +++++++++++++++++++++
>  source4/dsdb/wscript_build                      |   9 +
>  source4/param/pyparam.c                         |   7 +
>  source4/scripting/bin/samba_gpoupdate           | 147 ++++++++++++++++
>  source4/scripting/bin/wscript_build             |   2 +-
>  source4/scripting/wscript_build                 |   2 +-
>  source4/selftest/tests.py                       |   4 +
>  source4/torture/gpo/apply.c                     | 165 ++++++++++++++++++
>  source4/torture/gpo/gpo.c                       |  36 ++++
>  source4/torture/gpo/wscript_build               |  14 ++
>  source4/torture/wscript_build                   |   1 +
>  wscript_build                                   |   1 +
>  39 files changed, 1646 insertions(+), 82 deletions(-)
>