Removing smbclient Domain=... banner (Re: Default setting for "client max protocol" is NT1)

[Stefan Metzmacher]

Am 05.11.2016 um 18:15 schrieb Jeremy Allison:
> On Sat, Nov 05, 2016 at 10:51:54AM +0100, Stefan Metzmacher wrote:
>>
>> Yes, we want that, but not until every feature that works against
>> a Windows server with NT1 also work with SMB2/3.
>>
>> There were several bug reports, I'm not sure if they're still open.
> 
> Sounds like we can aim for this for 4.6 then !
> 
>> It would be really good to have all smbclient features tested in a
>> blackbox test,
>> I guess do a lot already, but I'm pretty sure not everything.
>> Once we have that we need to run that with -mSMB3_11 and if it works the
>> same way we can switch the default.
>>
>> (We also need to check all other client tools, in order to change the
>> default
>> for smb.conf)
>>
>> One thing I'm struggling with is this in
>> source3/libsmb/clidfs.c:do_connect():
>>
>>         if ( show_sessetup ) {
>>                 if (*c->server_domain) {
>>                         DEBUG(0,("Domain=[%s] OS=[%s] Server=[%s]\n",
>>
>> c->server_domain,c->server_os,c->server_type));
>>                 } else if (*c->server_os || *c->server_type) {
>>                         DEBUG(0,("OS=[%s] Server=[%s]\n",
>>                                  c->server_os,c->server_type));
>>                 }
>>         }
> 
> Oh that's *deeply* ugly :-). 'show_setup' needs to
> go from that code. I'll take a look :-).
> 
>> I'd really like to get rid of gensec_ntlmssp_server_domain().
>>
>> If we could remove this completely or replace with some wkssvc or srvsvc
>> RPC calls, to make it more reliable across the protocols.
>>
>> Or we simply just display the result of smbXcli_conn_remote_name()
>> and the used protocol string.
> 
> Sounds good to me ! Thanks Metze.

Can we get some progress here?
Should we just completely remove this for 4.7?

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170619/96bf6da2/signature.sig>