[PATCH] CTDB logging improvement for locking

[Martin Schwenke]

On Fri, 16 Jun 2017 16:30:33 +1000, Amitay Isaacs via samba-technical
<samba-technical at lists.samba.org> wrote:

> CTDB creates a lock helper to lock a record or a database.  If the
> lock helper is unable to take a lock for 10 seconds, ctdb will log a
> message and optionally launch a debug helper.
> 
> If there is record contention, then there can be hundreds of lock
> helpers waiting. When these lock helpers do not get lock for 10
> seconds (and increments of 10 seconds), all of them will log "unable
> to get RECORD lock for xx seconds".  Multiple such messages are quite
> useless and overwhelm syslogd when logging to syslog.
> 
> To avoid message storm, keep track of the messages which are logged
> and log once every 10 seconds per record.  Also, launch debug helper
> only once per 10 seconds.  This can avoid launching too many processes
> on a busy system.
> 
> Please review and push.

Reviewed-by: Martin Schwenke <martin at meltin.net>

Pushed...

peace & happiness,
martin