Minor inconsistency between SMB_VFS_GET_QUOTA and SMB_VFS_SET_QUOTA

Richard Sharpe realrichardsharpe at gmail.com
Thu Jun 15 20:38:48 UTC 2017

On Thu, Jun 15, 2017 at 10:41 AM, Jeremy Allison <jra at samba.org> wrote:
> On Thu, Jun 15, 2017 at 10:37:12AM -0700, Richard Sharpe via samba-technical wrote:
>> There is a minor inconsistency between the above two.
>> GET_QUOTA takes a path while SET_QUOTA does not (and gets the path
>> form the connect path in the connection structure pointed to by the
>> handle.
>> It seems there is no reason for this inconsistency so I will submit a
>> patch later today for Master.
> If you're adding a path-based call make sure to use struct smb_filename *,
> not char *.

Well, I was thinking of eliminating the path argument altogether
because we don't support it on SET_QUOTA, but I do not understand what
is being done in disk_quotas ... so I need to think about it some

Richard Sharpe

More information about the samba-technical mailing list