[PATCH] Fix the FreeBSD build

Andrew Bartlett abartlet at samba.org
Wed Jun 14 10:24:22 UTC 2017


On Fri, 2017-06-09 at 11:49 +1200, Andrew Bartlett via samba-technical
wrote:
> On Thu, 2017-06-08 at 16:05 -0700, Jeremy Allison via samba-technical
> wrote:
> > On Wed, Jun 07, 2017 at 10:09:50PM +1200, Andrew Bartlett via samba-
> > technical wrote:
> > > On Wed, 2017-06-07 at 11:24 +0200, Ralph Böhme via samba-technical
> > > wrote:
> > > > Hi Gary,
> > > > 
> > > > On Tue, Jun 06, 2017 at 11:12:50AM +1200, Gary Lockyer via samba-
> > > > technical wrote:
> > > > > I don't see a problem, I was hoping to have the wrapped version
> > > > > of
> > > > > strerror_r done on Friday.  But it's causing issues with
> > > > > hiemdal, and
> > > > > I've yet to get a clean test run, which suggests I'm still
> > > > > missing
> > > > > something.
> > > > 
> > > > ok, thanks for confirming. So I went ahead and pushed Volker's
> > > > fix.
> > > 
> > > I think I finally have a patch set that allows us to use
> > > strerror_r. 
> > > It certainly was a fight!
> > 
> > LGTM. RB+.
> 
> Thanks.  We were running internal builds on this and got some odd
> errors during test, and haven't had time to work out if it is this
> (somehow?) or what is going on, so we will pick this back up when
> things are a little less frantic.

I note that metze pushed this yesterday.  I don't know what was going
on with our earlier builds, I see no signs of the odd errors that
spooked us last week on branches that include this patch.

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list