[PATCH] CTDB logging improvements

Amitay Isaacs amitay at gmail.com
Tue Jun 13 05:55:03 UTC 2017

On Tue, Jun 13, 2017 at 3:46 PM, Martin Schwenke via samba-technical <
samba-technical at lists.samba.org> wrote:

> 2 separate commits:
> * ctdb-common: Log a count of dropped messages with non-blocking logging
>   The non-blocking logging variants can currently silently drop messages
>   when the socket queue fills.
>   In this case, count the number of dropped messages and attempt to log
>   a message about dropped log messages when the next message is logged.
> * ctdb-scripts: Compact server-end TCP connection killing output
>   When thousands of connections are being killed the logs are flooded
>   with information about connections that should be killed.  When some
>   connections are not killed then the number not killed is printed.
>   This is the wrong way around!  When debugging "fail-back" problems,
>   it is important to know details of connections that were *not*
>   killed.  It is almost never important to know the full list of all
>   connections that were *supposed* to be killed.
>   Instead, print a summary showing how many connections of the total
>   were killed.  If any were not killed then print a list of remaining
>   connections.
>   Update unit tests: infrastructure for fake TCP connections,
>   existing, test cases, add new test cases.
> Please review and maybe push...
> peace & happiness,
> martin

Reviewed-by: Amitay Isaacs <amitay at gmail.com>


More information about the samba-technical mailing list