[PATCH] Fix flapping user_virtualCryptSHA and user_wdigest tests

Andrew Bartlett abartlet at samba.org
Fri Jun 9 07:43:03 UTC 2017


On Fri, 2017-06-09 at 09:08 +0200, Andreas Schneider via samba-
technical wrote:
> On Friday, 9 June 2017 02:02:25 CEST Jeremy Allison via samba-technical wrote:
> > On Fri, Jun 09, 2017 at 07:00:53AM +1200, Gary Lockyer via samba-technical 
> 
> wrote:
> > > Both tests use "samba-tool user create" to create a user, with a random
> > > password. If the random password contained shell metacharacters or '-'
> > > failures like
> > > https://git.samba.org/autobuild.flakey.sn-devel-144/2017-06-03-1418/samba.
> > > stdout occurred.
> > > 
> > > This patch restricts the generated passwords to [A-Za-z0-9]
> > > 
> > > 
> > > Review and push appreciated
> > 
> > Oh good catch ! LGTM. Reviewed-by: Jeremy Allison <jra at samba.org>
> 
> RB+ will push ...

Thanks Andreas.  I've also reviewed it and it is in autobuild at the
moment, however until we get past this flapping nonsense that doesn't
really count for much :-)

On the flapping tests, I think I'm getting closer, but it may still be
another week before the locking patches pass all the tests.  We think
that will fix most of the DRS issues, but we have thought that before
:-)

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list