[PATCH] Fix smbclient regression not printing session setup anymore

Andreas Schneider asn at samba.org
Wed Jun 7 15:52:02 UTC 2017

On Wednesday, 7 June 2017 17:27:46 CEST Stefan Metzmacher wrote:
> Hi Andreas,

Hi Metze,

> I'm asking myself for a while if we really need to maintain printing
> out this information at all. With SMB2 and Kerberos we're currently
> not able to print anything.

currently this is a regression in Samba 4.6. If you do not want to have 
anything printed you should remove it in Samba 4.7 but we need to fix the 
regression in Samba 4.6.

At least I have to in RHEL.

> Is this only used on the smbclient binary or do we trigger this
> also via other code paths?

It is only used by smbclient.

> Would it be possible to skip this completely?
> Or use wkssvc_NetWkstaInfo100 and/or srvsvc_NetSrvInfo101
> to get these values more reliable?

I'm fine with both.

> https://git.samba.org/?p=samba.git;a=commitdiff;h=b6f87af427a1fa2bd39766
> makes we a bit nervous as we can now have NULL pointers
> in cli->server_{type,os,domain} and I guess not all code
> is prepared for that see,
> https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=a5fb0a4cac3a19b0
> 4
> for where we make use of them.
> That's why I created the attached change to restore the 4.5
> behaviour.

Then better do it like 4.5 at least to fix it in Samba 4.6


Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org

More information about the samba-technical mailing list