[PATCH] Fix the FreeBSD build

[Gary Lockyer]

I don't see a problem, I was hoping to have the wrapped version of
strerror_r done on Friday.  But it's causing issues with hiemdal, and
I've yet to get a clean test run, which suggests I'm still missing
something.

Gary

On 05/06/17 22:51, Ralph Böhme via samba-technical wrote:
> On Sat, Jun 03, 2017 at 07:54:37PM +1200, Andrew Bartlett wrote:
>> On Fri, 2017-06-02 at 15:14 +0200, Ralph Böhme via samba-technical
>> wrote:
>>> On Fri, Jun 02, 2017 at 01:42:08PM +0200, Volker Lendecke via samba-technical wrote:
>>>> Hi!
>>>>
>>>> Until Gary Lockyer finds time to fix the FreeBSD build the way he
>>>> intends to fulfill thread safety requirements to the ldb modules and
>>>> make ldb fully multi-threaded (which I will applause greatly when
>>>> done, thanks Gary for attacking this hard problem!!), this might be an
>>>> interesting patch for FreeBSD users.
>>>
>>> lgtm. Let's give Gary some time to respond, otherwise I'll push tomorrow.
>>
>> Gary was working on it when I was last in the office, re-using the
>> logic from the Heimdal build.  While LDB isn't likely to be thread-safe 
>> any time soon, Gary was keen to build the right foundations for all of
>> Samba to move in that direction (with some other library likely the
>> first to actually qualify), rather than just patch it to strerror().
> 
> well, the build is broken *now* and pushing the fix doesn't hinder Gary from
> continuing to work on a better fix that can go on-top of the build-fix. Or am I
> missing something?
> 
> Gary, do you see any problem with pushing the fix and providing a proper
> strerror_r replacement on-top? I don't think we should leave the master build
> broken on FreeBSD for too long.
> 
> Cheerio!
> -slow
> 



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170606/83fe351d/signature.sig>