[PATCH] vfs_gpfs: Fix compile error in gpfsacl_sys_acl_set_fd

Jeremy Allison jra at samba.org
Fri Jun 2 23:37:43 UTC 2017


On Fri, Jun 02, 2017 at 04:20:54PM -0700, Christof Schmitt via samba-technical wrote:
> From 939499a9c291de06257dfe3bb9896cef1427b8b5 Mon Sep 17 00:00:00 2001
> From: Christof Schmitt <cs at samba.org>
> Date: Fri, 2 Jun 2017 16:16:16 -0700
> Subject: [PATCH] vfs_gpfs: Fix compile error in gpfsacl_sys_acl_set_fd
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> ../source3/modules/vfs_gpfs.c: In function ‘gpfsacl_sys_acl_set_fd’:
> ../source3/modules/vfs_gpfs.c:1280:6: error: passing argument 2 of ‘gpfsacl_sys_acl_set_file’ from incompatible pointer type [-Werror]
>       SMB_ACL_TYPE_ACCESS, theacl);
>       ^
> ../source3/modules/vfs_gpfs.c:1235:12: note: expected ‘const struct smb_filename *’ but argument is of type ‘char *’
>  static int gpfsacl_sys_acl_set_file(vfs_handle_struct *handle,
> 
> Signed-off-by: Christof Schmitt <cs at samba.org>
> ---
>  source3/modules/vfs_gpfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/source3/modules/vfs_gpfs.c b/source3/modules/vfs_gpfs.c
> index 4dc9f76..aeb0836 100644
> --- a/source3/modules/vfs_gpfs.c
> +++ b/source3/modules/vfs_gpfs.c
> @@ -1276,7 +1276,7 @@ static int gpfsacl_sys_acl_set_fd(vfs_handle_struct *handle,
>  		return SMB_VFS_NEXT_SYS_ACL_SET_FD(handle, fsp, theacl);
>  	}
>  
> -	return gpfsacl_sys_acl_set_file(handle, fsp->fsp_name->base_name,
> +	return gpfsacl_sys_acl_set_file(handle, fsp->fsp_name,
>  					SMB_ACL_TYPE_ACCESS, theacl);
>  }
>  
> -- 
> 1.8.3.1

Thanks Christof, sorry for the error. I wasn't able to compile
the gpfs vfs module when doing the big VFS char * -> smb_filename
refactor. RB+ and pushed.



More information about the samba-technical mailing list