Shouldn't this test be "short_name != NULL"? On 6/1/17 09:45, Andreas Schneider via samba-technical wrote: > - if (*short_name == '\0') { > + if (*short_name[0] == '\0') { > *short_name = talloc_strdup(mem_ctx, *long_name); > }