[PATCH] Harden Samba module functions

Andrew Bartlett abartlet at samba.org
Thu Jun 1 08:41:26 UTC 2017

On Thu, 2017-06-01 at 10:15 +0200, Andreas Schneider via samba-
technical wrote:
> Take a look at this patchset.

G'Day Andreas,

Sorry to bike-shed this, but could you just set an environment variable
rather than modify the file system (and so have what could look like
/tmp races)?

I think you should also load the module once in the successful way
(rather than auth/skel) and once with the full path, so we don't get a
false positive this test if the module is just busted.

Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list