[PATCH] ctdb-common: Set close-on-exec when creating PID file (bug 12898)

[Volker Lendecke]

On Mon, Jul 31, 2017 at 11:37:54AM +0200, Volker Lendecke wrote:
> On Mon, Jul 31, 2017 at 03:44:46PM +1000, Martin Schwenke wrote:
> > Patch attached.
> > 
> > Obvious extensions to this include:
> > 
> > * Move pidfile_context_create() to lib/util/pidfile.*
> > 
> >   This means that ctdb/common/pidfile.* would be
> >   completely removed.  Also pidfile_path_create() and pidfile_close()
> >   would be static.
> > 
> > * Add documentation to lib/util/pidfile.h
> > 
> >   I didn't want to do this until I knew whether pidfile_path_create()
> >   and pidfile_close() will disappear from there.  ;-)
> > 
> > Please review and maybe push...
> 
> Great, thanks! Pushed!

Hmm. Fails with

[50(716)/2182 at 11m38s] wafsamba.duplicate_symbols
Waf: Entering directory `/memdisk/vlendec/a/b456000/samba/bin'
        Selected embedded Heimdal build
[4090/4214] symbol duplicate checking:
Waf: Leaving directory `/memdisk/vlendec/a/b456000/samba/bin'
Build failed:
default/source3/lib/netapi/examples/localgroup/localgroup_setinfo: Symbol pidfile_close linked in multiple libraries ['samba-util', '/lib/x86_64-linux-gnu/libbsd.so.0.6.0']
UNEXPECTED(failure):
wafsamba.duplicate_symbols.duplicate_symbols(none)
REASON: Exception: Exception:

Can you check?

Thanks, Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de