[PATCH] Small fixes for schannel_state_tdb.c

[Volker Lendecke]

Hi!

Review appreciated!

Thanks, Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
From e18f98ebb57abcceeedd6e75e34b55c84240ca0a Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Wed, 26 Jul 2017 17:22:42 +0200
Subject: [PATCH 1/2] lib: Fix a typo

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 libcli/auth/schannel_state_tdb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libcli/auth/schannel_state_tdb.c b/libcli/auth/schannel_state_tdb.c
index d884279bdb2..f55ae0ffb56 100644
--- a/libcli/auth/schannel_state_tdb.c
+++ b/libcli/auth/schannel_state_tdb.c
@@ -439,7 +439,7 @@ NTSTATUS schannel_fetch_challenge_tdb(struct db_context *db_sc,
 }
 
 /******************************************************************************
- Wrapper around schannel_fetch_session_key_tdb()
+ Wrapper around schannel_fetch_challenge_tdb()
  Note we must be root here.
 
 *******************************************************************************/
-- 
2.11.0


From c4b4d5dabb6fa7c42eb69b7a6b96dc23b6068708 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Wed, 26 Jul 2017 17:24:51 +0200
Subject: [PATCH 2/2] lib: Fix an error path memleak

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 libcli/auth/schannel_state_tdb.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libcli/auth/schannel_state_tdb.c b/libcli/auth/schannel_state_tdb.c
index f55ae0ffb56..6a19823f639 100644
--- a/libcli/auth/schannel_state_tdb.c
+++ b/libcli/auth/schannel_state_tdb.c
@@ -263,11 +263,13 @@ NTSTATUS schannel_save_creds_state(TALLOC_CTX *mem_ctx,
 
 	db_sc = open_schannel_session_store(tmpctx, lp_ctx);
 	if (!db_sc) {
-		return NT_STATUS_ACCESS_DENIED;
+		status = NT_STATUS_ACCESS_DENIED;
+		goto fail;
 	}
 
 	status = schannel_store_session_key_tdb(db_sc, tmpctx, creds);
 
+fail:
 	talloc_free(tmpctx);
 	return status;
 }
-- 
2.11.0