[PATCH] Add DNS widkcard support.

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Jul 27 06:10:22 UTC 2017

On Thu, Jul 27, 2017 at 03:31:01PM +1200, Andrew Bartlett via samba-technical wrote:
> On Thu, 2017-07-27 at 14:00 +1200, Gary Lockyer via samba-technical
> wrote:
> > Patches to add support for DNS wild card records.
> > 
> > Tests validated against Windows server 2012 R2
> > 
> > Reviews and push appreciated
> Thanks Gary,
> My biggest concern here is in the re-parsing of the DN as a string, and
> then the manipulations required to try and create the wildcard
> searches. 
> Can we instead parse this into a struct ldb_parse_tree and use routines
> like ldb_dn_get_rdn_name() and ldb_dn_get_rdn_val() to work out the
> bits you want from the original DN, and use LDB_SCOPE_ONELEVEL to
> ensure you don't look further down the tree than you expect.
> That should make the string work here seem much more mundane. 

Also, a bit nit-picking: Passing down boolean flags is always
completely opaque for the caller. "true" and "false" don't have a
visible meaning themselves, you will always have to look up what this
exactly means. Can we make two routines with obvious names for the
external callers? If absolutely required, they can then pass down a
flag to an internal routine. But if that can be avoided also, even

Thanks, Volker

SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list