[PATCH] s3: smbd: Modernize Avahi DEBUG macros and long if statements

Omri Mor omri50 at gmail.com
Thu Jul 27 00:38:38 UTC 2017

Hi all,

This patch modernizes the DEBUG macros and breaks up long if statements in the smbd Avahi code.
It paves the way for adding advertisement of _adisk._tcp when fruit:time machine is enabled, as part of the Time Machine/FULLSYNC patch.

Would it be useful to do a search throughout the code for old-style DEBUG macros and replace them with the modern equivalent?
I also recall seeing different DEBUG levels for the same conditions (allocation failure/OOM in the specific case I was looking at)—is there a standard for what levels should be used?
I suppose it would come down to whether allocation failure/OOM requires an error, a warning, or a notice.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-smbd-Modernize-Avahi-DEBUG-macros-and-long-if-sta.patch
Type: application/octet-stream
Size: 5467 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170726/1ddf014d/0001-s3-smbd-Modernize-Avahi-DEBUG-macros-and-long-if-sta.obj>

More information about the samba-technical mailing list