s3-printing: precreate DriverStore directories patch

Jeremy Allison jra at samba.org
Wed Jul 26 16:39:09 UTC 2017


On Wed, Jul 26, 2017 at 05:35:03AM +0200, Andreas Schneider wrote:
> The branch, master has been updated
>        via  8865ded s3-printing: precreate DriverStore directories.
>        via  2621a2d s3-printing: add spoolss_get_short_filesys_environment function.
>        via  a17cb9e s3-printing: pre-create color and PCC directories under print$.
>       from  5005a3a libsmb: Enable "cli_notify" for SMB2+
> 
> https://git.samba.org/?p=samba.git;a=shortlog;h=master
> 
> 
> - Log -----------------------------------------------------------------
> commit 8865dede5703a93c71fc2cb9417688f751ea2c69
> Author: G√ľnther Deschner <gd at samba.org>
> Date:   Mon Sep 12 21:00:18 2016 +0200
> 
>     s3-printing: precreate DriverStore directories.
>     
>     Guenther
>     
>     Signed-off-by: Guenther Deschner <gd at samba.org>
>     Reviewed-by: Andreas Schneider <asn at samba.org>

Guenther and Andreas - there are missing
NULL return checks on the calls to
state_path() in this patch.

(state_path() returns a talloc'ed string, which
can return NULL).

Can you add the checks in and post for review
please ?

Thanks,

Jeremy.



More information about the samba-technical mailing list