[PATCH] Use the same process and krb5 ccache when invoking samba-tool in drs tests
asn at samba.org
Wed Jul 26 05:58:16 UTC 2017
On Tuesday, 25 July 2017 22:07:24 CEST Andrew Bartlett via samba-technical
> On Sat, 2017-07-22 at 09:00 +1200, Andrew Bartlett via samba-technical
> > On Sat, 2017-07-22 at 08:19 +1200, Andrew Bartlett via samba-technical
> > wrote:
> > > This patch removes a number of calls to fork() inside python, and
> > > instead of passing -Uusername%password on the internal command line, we
> > > pass around the name of the krb5 credentials cache we already have.
> > >
> > > I've not been able to quantify the speed benefits - there seems to be
> > > more noise than signal in the timing here, hence my other patch
> > > reducing idle time, but when we had these tests under perf/FlameGraph
> > > the string2key routines really dominated the time what was spent on the
> > > CPU.
> > Actually, if I use my tevent_immediate patch as the baseline, it saves
> > about 80 seconds per repl_move test on my laptop.
> > Aside from making the timing more reliable, it is however independent
> > of that patch.
> > > Earlier in the thread, Jeremy looked over the C parts, but if someone
> > > could look over the rest that would be great!
> > >
> > > Please review!
> Can I please get a review on this patch series? As above, it makes a
> measurable reduction to the time taken for make test, which we would
> all appreciate.
I was busy with metze his async spnego patchset, that one is the next on my
Andreas Schneider GPG-ID: CC014E3D
Samba Team asn at samba.org
More information about the samba-technical