[PATCH] Remove all uses of talloc_autofree_context() from our code (except for test)

Jeremy Allison jra at samba.org
Tue Jul 25 20:47:20 UTC 2017


On Wed, Jul 26, 2017 at 08:38:37AM +1200, Andrew Bartlett wrote:
> On Tue, 2017-07-25 at 13:28 -0700, Jeremy Allison wrote:
> > 
> > As pointed out by Volker on the phone, I'm conflating two issues here :-).
> 
> > That way I get talloc_autofree_context() removed from
> > our code and hopefully will prevent anyone from
> > re-adding it, but you all still get "smbcontrol smbd pool-usage"
> > still working.
> > 
> > Does that sound like a plan ?
> 
> Yes.  (I'll look over the specific patch details later today).

Thanks, much appreciated.

Thinking about it some more, you're actually correct about
this improving the libsmbclient libs without the null tracking
removal change - the gnome VFS programs that use libsmbclient
don't turn on null tracking. So I may have more room to experiment
there..

> > I hate you all equally (but at least I haven't wasted several
> > months worth of work :-) :-) :-).
> 
> Don't worry, it was all worth it to have Volker and myself on a unity
> ticket ;-)

That's good management for you. Providing a target for everyone to
stick pins in :-) :-).



More information about the samba-technical mailing list