[PATCH] Remove all uses of talloc_autofree_context() from our code (except for test)
abartlet at samba.org
Tue Jul 25 20:03:12 UTC 2017
On Tue, 2017-07-25 at 12:37 -0700, Jeremy Allison via samba-technical
> On Tue, Jul 25, 2017 at 09:24:57PM +0200, Volker Lendecke wrote:
> > On Tue, Jul 25, 2017 at 09:05:07AM -0700, Jeremy Allison wrote:
> > > Here is a patch to finally remove all uses of
> > > talloc_autofree_context() from the Samba code
> > > tree, except for the talloc tests that exercise
> > > the talloc_autofree_context() functionality.
> > >
> > > The final patch removes the calls to:
> > >
> > > talloc_enable_null_tracking()
> > >
> > > inside nmbd, smbd, winbind and samba
> > Does "smbcontrol smbd pool-usage" still
> > work after this change?
> No. If we're not using the global null_context within
> talloc anymore, then pool usage doesn't have a central
> place to track all allocations off it.
That's a blocker for me. We only just got access to "smbcontrol smbd
pool-usage" in the AD DC, and it is one of the few tools for trying to
case down memory leaks at a customer installation.
I would be very sad to loose it now, without replacement.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical